On Wed, 2023-11-29 at 06:47 -0800, Guenter Roeck wrote: > On 11/29/23 00:35, Nuno Sá wrote: > [ ... ] > > > > > For the record, I do care about the code I submit and missing 'static' is quite > > embarrassing, yes. The only reason why I still dind't send the v3 fixing that is > > because I'm giving more time to see if you can review some of the other changes. > > I'm > > pretty sure I'll be asked to change more things in v2 (as stated in the cover, > > there > > are still some shady things in the driver). > > > > NP, but you (and others) will have to accept that your patches end up at the end > of my lowest-priority review queue if 0-day or checkpatch or builds with W=1 > end up reporting problems. My time is limited, and I am extremely wary of having > to keep telling people to run checkpatch or builds with W=1. > > Guenter > Hmm I see... So I might just send a v3 with the feedback I got so far plus getting 0- day fixed. That way, I might get out of the lowest-priority queue :) - Nuno Sá