On 27/11/2023 17:03, Andy Shevchenko wrote: > On Mon, Nov 27, 2023 at 09:12:14AM +0100, Krzysztof Kozlowski wrote: >> On 27/11/2023 09:10, Krzysztof Kozlowski wrote: > > ... > >> Wait, this was not even unusual test, just standard compile, which means >> you did not do basic tests on your end. You must build your new driver >> with W=1, smatch, sparse and coccinelle before sending upstream. > > Well, sparse is lagging in development, for the last year it's at least two > times it broke kernel builds because of being not ready for the new stuff used > in the kernel. Do we have anybody to sync this? I don't think so, hence > requiring this from developer is doubtful. Otherwise I agree, that basic > compilation with GCC/LLVM must be done. Sparse still detects several issues and handles lock annotations, so it is useful. But if you disagree with that part, I still insist on Smatch (which is actively developed and works great) and Coccinelle (also actively developed). Best regards, Krzysztof
