On Thu, 23 Nov 2023 15:33:04 +0200 Gal Pressman wrote: > On 22/11/2023 1:33, Jakub Kicinski wrote: > > Last but not least please keep the field check you moved to the drivers > > in the core. Nobody will remember to check that other drivers added the > > check as well. > > The wording of this sentence is a bit confusing, so I might be repeating > what you already said, but this patchset needs to make sure that drivers > that do not support the new symmetric flag return an error instead of > silently ignoring it. Ah, good point! That, too. I was referring to what changed in v5, from the change long: v5: move sanity checks from ethtool/ioctl.c to ice's and iavf's rxfnc drivers entries (patches 5 and 6).