On Mon, 20 Nov 2023 13:56:09 -0700 Ahmed Zaki wrote: > + * @data: Extension for the RSS hash function. Valid values are one of the > + * %RXH_HFUNC_*. @data is way too generic. Can we call this key_xfrm? key_preproc? > +/* RSS hash function data > + * XOR the corresponding source and destination fields of each specified > + * protocol. Both copies of the XOR'ed fields are fed into the RSS and RXHASH > + * calculation. > + */ > +#define RXH_HFUNC_SYM_XOR (1 << 0) We need to mention somewhere that sym-xor is unsafe, per Alex's comments. > +++ b/include/uapi/linux/ethtool_netlink.h You need to fill in the details in: Documentation/networking/ethtool-netlink.rst and Documentation/netlink/specs/ethtool.yaml Last but not least please keep the field check you moved to the drivers in the core. Nobody will remember to check that other drivers added the check as well. -- pw-bot: cr
