Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Köry Maincent <kory.maincent@xxxxxxxxxxx>
Subject: Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
From: Andrew Lunn <andrew@xxxxxxx>
Date: Wed, 22 Nov 2023 18:49:50 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Luis Chamberlain <mcgrof@xxxxxxxxxx>, Russ Weight <russ.weight@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx
In-reply-to: <20231122181647.06d9c3c9@kmaincent-XPS-13-7390>
References: <20231116-feature_poe-v1-0-be48044bf249@bootlin.com> <20231116-feature_poe-v1-9-be48044bf249@bootlin.com> <2ff8bea5-5972-4d1a-a692-34ad27b05446@lunn.ch> <20231122171112.59370d21@kmaincent-XPS-13-7390> <04f59e77-134b-45b2-8759-84b8e22c30d5@lunn.ch> <20231122181647.06d9c3c9@kmaincent-XPS-13-7390>

> I would say it never supposed to happen.
> I never faced the issue playing with the controller. The first communication is
> a simple i2c_master_recv of the controller status without entering the
> pd692x0_sendrecv_msg function, therefore it won't be an issue.

Great. Do a pr_info() or similar and keep holding the lock. KISS.

       Andrew

References:
- [PATCH net-next 0/9] net: Add support for Power over Ethernet (PoE)
  - From: Kory Maincent
- [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
  - From: Kory Maincent
- Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
  - From: Andrew Lunn
- Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
  - From: Köry Maincent
- Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
  - From: Andrew Lunn
- Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
  - From: Köry Maincent

Prev by Date: Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
Next by Date: Re: [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time stamping layer be selectable
Previous by thread: Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
Next by thread: Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]