On 31/10/2023 17:20, Jakub Kicinski wrote: > On Tue, 31 Oct 2023 09:14:58 -0600 Ahmed Zaki wrote: >> Do you mean add vendor-specific implementation details to common docs? >> Not sure if I have seen this before. Any examples? >> >> Or, we can add a note in ethtool doc that each vendor's implementation >> is different and "Refer to your vendor's specifications for more info". > > Gal, can you shed any more detail on who your implementation differs? > It will help the discussion, and also - I'm not sure how you can do > xor differently.. Sure, IIUC, ice's implementation does a: (SRC_IP ^ DST_IP, SRC_IP ^ DST_IP, SRC_PORT ^ DST_PORT, SRC_PORT ^ DST_PORT) Our implementation isn't exactly xor, it is: (SRC_IP | DST_IP, SRC_IP ^ DST_IP, SRC_PORT | DST_PORT, SRC_PORT ^ DST_PORT) The way I see it, the xor implementation should be clearly documented, so no one uses the same flag with a different implementation by mistake.
