On 9/26/23 15:02, Luck, Tony wrote: >>>>> +#include <linux/mod_devicetable.h> >>>> >>>> I didn't see the need for this include. >>> >>> struct x86_cpu_id is defined in this #include file. >> >> Actually, the file <asm/cpu_device_id.h> already includes the above file. > > It does today. Will it include it next week when somebody has to > re-arrange things to resolve some #include dependency? > > I thought there was a guideline somewhere that says to #include > the files that define the things you use. Not just rely on chains of > #includes. But some simple grep's haven't found that written in > Documentation/* Yea. correct. There is no guidelines. Lets keep the #include <linux/mod_devicetable.h> -- Thanks Babu Moger
