On 9/26/23 14:40, Luck, Tony wrote: >>> +#include <linux/mod_devicetable.h> >> >> I didn't see the need for this include. > > struct x86_cpu_id is defined in this #include file. Actually, the file <asm/cpu_device_id.h> already includes the above file. > >>> +static void snc_remap_rmids(int cpu) >> >> While adding the new functions, i see that new function names start with >> resctrl_ prefix. However, we are all not very consistent. Can ypu rename >> this function to resctrl_snc_remap_rmids? > > I try to put a subsystem prefix on any global symbols to avoid random > conflicts in other parts of the kernel. But I'm less sure of the value for > static functions and variables that are only visible inside a single ".c" > file. > > If it must have a prefix, should it be "intel_" rather than "resctrl_" to > indicate that it is an Intel specific function? If you add it it should be resctrl_. Thanks Babu > > >>> +static __init int get_snc_config(void) >> >> Same comment as above. > > Same answer. > > > Reinette: Any opinions on these? > > -Tony
