Hi Andrew, On 22/09/23 12:49 am, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> Yes, as "struct oa_tc6" and its members are not or going to be accessed >> in the MAC driver, I will consider this as an opaque structure and >> declare it as void *opaque_oa_tc6 in the MAC driver private structure >> "struct lan865x_priv" and will pass to the APIs exported from oa_tc6.c lib. >> >> Is my understanding correct? > > Yes. > > If the structure is going to be truly opaque, i suggest having it in > the C file, not the H file. Yes for sure, I will move it to oa_tc6.c file. Andrew, thanks a lot for all your comments. They are all really helping me to know/learn many things to improve my patches and coding style. Please keep supporting. Best Regards, Parthiban V > > Andrew
