> +struct oa_tc6 { > + struct spi_device *spi; > + bool ctrl_prot; > +}; Should this be considered an opaque structure which the MAC driver should not access the members? I don't see anything setting ctrl_prot here. Does it need a setter and a getter? Andrew