Hi Jonathan, >> Follow Randy's advice [1] to move >> Documentation/translations/zh_TW/dev-tools/sparse.txt >> to >> Documentation/translations/zh_TW/dev-tools/sparse.rst >> >> [1] https://lore.kernel.org/lkml/bfab7c5b-e4d3-d8d9-afab-f43c0cdf26cf@inf= >radead.org/ > >So the right way to do this would be to simply say something like >"Convert sparse.txt to RST", then add a Suggested-by: tag to credit >Randy.=20 Got it, I will submit v2 with this subject and add Suggested-by: tag to credit Randy. > >> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> Signed-off-by: Min-Hua Chen <minhuadotchen@xxxxxxxxx> >> --- >> .../dev-tools/{sparse.txt =3D> sparse.rst} | 31 ++++++------------- >> 1 file changed, 10 insertions(+), 21 deletions(-) >> rename Documentation/translations/zh_TW/dev-tools/{sparse.txt =3D> spars= >e.rst} (71%) > >You're not adding this new document to a toctree anywhere; that will add >a warning and this file won't be a part of the docs build. I will fix this in v2. >> diff --git a/Documentation/translations/zh_TW/dev-tools/sparse.txt b/Docu= >mentation/translations/zh_TW/dev-tools/sparse.rst >> similarity index 71% >> rename from Documentation/translations/zh_TW/dev-tools/sparse.txt >> rename to Documentation/translations/zh_TW/dev-tools/sparse.rst >> index 6d2d088b1060..2f632f6ce8e8 100644 >> --- a/Documentation/translations/zh_TW/dev-tools/sparse.txt >> +++ b/Documentation/translations/zh_TW/dev-tools/sparse.rst >> @@ -1,33 +1,22 @@ >> -=EF=BB=BFChinese translated version of Documentation/dev-tools/sparse.rst >> - >> -If you have any comment or update to the content, please contact the >> -original document maintainer directly. However, if you have a problem >> -communicating in English you can also ask the Chinese maintainer for >> -help. Contact the Chinese maintainer if this translation is outdated >> -or if there is a problem with the translation. >> +=EF=BB=BFCopyright 2004 Linus Torvalds >> +Copyright 2004 Pavel Machek <pavel@xxxxxx> >> +Copyright 2006 Bob Copeland <me@xxxxxxxxxxxxxxx> >>=20=20 >> -Traditional Chinese maintainer: Hu Haowen <src.res@xxxxxxxx> > >So you are removing a fair amount of text here, much of which I cannot >read. Why are you doing that? In any case, that would appear to be a >change that is independent of the format conversion, and should thus be >in its own patch. The text I removed is replaced by '.. include:: ../disclaimer-zh_TW.rst'. I will keep the original text and change it in another change. thanks, Min-Hua > >Thanks, > >jon >
