On 8/2/23 09:18, Jakub Kicinski wrote: > Using PP_FLAG_DMA_SYNC_DEV is a bit confusing. It was perhaps > more obvious when it was introduced but the page pool use > has grown beyond XDP and beyond packet-per-page so now > making the heads and tails out of this feature is not > trivial. > > Obviously making the API more user friendly would be > a better fix, but until someone steps up to do that > let's at least document what the parameters are. > > Relevant discussion in the first Link. > > Link: https://lore.kernel.org/all/20230731114427.0da1f73b@xxxxxxxxxx/ > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. > --- > v2: > - s/sync'/sync/ and other fixes from Randy > v1: https://lore.kernel.org/all/20230801203124.980703-1-kuba@xxxxxxxxxx/ > > CC: hawk@xxxxxxxxxx > CC: ilias.apalodimas@xxxxxxxxxx > CC: corbet@xxxxxxx > CC: linux-doc@xxxxxxxxxxxxxxx > CC: Michael Chan <michael.chan@xxxxxxxxxxxx> > CC: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > CC: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > --- > Documentation/networking/page_pool.rst | 34 ++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) -- ~Randy
