Hi Reinette, On 5/5/23 16:28, Reinette Chatre wrote: > Hi Babu, > > On 5/5/2023 12:04 PM, Moger, Babu wrote: >> [AMD Official Use Only - General] >> >> Hi Reinette, >> >>> -----Original Message----- >>> From: Reinette Chatre <reinette.chatre@xxxxxxxxx> >>> Sent: Friday, May 5, 2023 1:54 PM >>> To: Moger, Babu <Babu.Moger@xxxxxxx>; corbet@xxxxxxx; >>> tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; bp@xxxxxxxxx >>> Cc: fenghua.yu@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; >>> hpa@xxxxxxxxx; paulmck@xxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; >>> quic_neeraju@xxxxxxxxxxx; rdunlap@xxxxxxxxxxxxx; >>> damien.lemoal@xxxxxxxxxxxxxxxxxx; songmuchun@xxxxxxxxxxxxx; >>> peterz@xxxxxxxxxxxxx; jpoimboe@xxxxxxxxxx; pbonzini@xxxxxxxxxx; >>> chang.seok.bae@xxxxxxxxx; pawan.kumar.gupta@xxxxxxxxxxxxxxx; >>> jmattson@xxxxxxxxxx; daniel.sneddon@xxxxxxxxxxxxxxx; Das1, Sandipan >>> <Sandipan.Das@xxxxxxx>; tony.luck@xxxxxxxxx; james.morse@xxxxxxx; >>> linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >>> bagasdotme@xxxxxxxxx; eranian@xxxxxxxxxx; christophe.leroy@xxxxxxxxxx; >>> jarkko@xxxxxxxxxx; adrian.hunter@xxxxxxxxx; quic_jiles@xxxxxxxxxxx; >>> peternewman@xxxxxxxxxx >>> Subject: Re: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags > > (is it possible to trim the headers in your replies?) > You mean Company Header.. Sure.. Will do. > ... > >>>>> On 4/17/2023 4:34 PM, Babu Moger wrote: >>>>>> Remove unnecessary rftype flags to avoid multiple indirection. >>>>> >>>>> Could you please elaborate what makes these flags unnecessary? >>>> >>>> Yea. Probably should not say unnecessary. >>>> How about this ? >>>> "rftype flags have two prefixes, RFTYPE_ and RF_. Remove the flag names >>> with suffix RF_ and avoid indirection." >>> >>> I do not think that having a different prefix is a motivation for a flag to be >>> removed. Having a different prefix could rather be a motivation for a flag to be >>> renamed to a consistent name. >>> >>> Could you please describe the problem being solved? >> >> Motivation for these changes. >> 1. Remove the naming inconsistency >> 2. Remove the indirection >> 3. Make it easier for adding new flags >> > > Could you please create a coherent changelog that follows the guidance > of the maintainer doc? Some details about why the indirection needs to be > removed and how this makes it easier to add new flags? Sure. Will try to address it next revision. -- Thanks Babu Moger
