Hi Babu, On 5/5/2023 11:31 AM, Moger, Babu wrote: > [AMD Official Use Only - General] > > Hi Reinette, > >> -----Original Message----- >> From: Reinette Chatre <reinette.chatre@xxxxxxxxx> >> Sent: Thursday, May 4, 2023 1:59 PM >> To: Moger, Babu <Babu.Moger@xxxxxxx>; corbet@xxxxxxx; >> tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; bp@xxxxxxxxx >> Cc: fenghua.yu@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; >> hpa@xxxxxxxxx; paulmck@xxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; >> quic_neeraju@xxxxxxxxxxx; rdunlap@xxxxxxxxxxxxx; >> damien.lemoal@xxxxxxxxxxxxxxxxxx; songmuchun@xxxxxxxxxxxxx; >> peterz@xxxxxxxxxxxxx; jpoimboe@xxxxxxxxxx; pbonzini@xxxxxxxxxx; >> chang.seok.bae@xxxxxxxxx; pawan.kumar.gupta@xxxxxxxxxxxxxxx; >> jmattson@xxxxxxxxxx; daniel.sneddon@xxxxxxxxxxxxxxx; Das1, Sandipan >> <Sandipan.Das@xxxxxxx>; tony.luck@xxxxxxxxx; james.morse@xxxxxxx; >> linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> bagasdotme@xxxxxxxxx; eranian@xxxxxxxxxx; christophe.leroy@xxxxxxxxxx; >> jarkko@xxxxxxxxxx; adrian.hunter@xxxxxxxxx; quic_jiles@xxxxxxxxxxx; >> peternewman@xxxxxxxxxx >> Subject: Re: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags >> >> Hi Babu, >> >> On 4/17/2023 4:34 PM, Babu Moger wrote: >>> Remove unnecessary rftype flags to avoid multiple indirection. >> >> Could you please elaborate what makes these flags unnecessary? > > Yea. Probably should not say unnecessary. > How about this ? > "rftype flags have two prefixes, RFTYPE_ and RF_. Remove the flag names with suffix RF_ and avoid indirection." I do not think that having a different prefix is a motivation for a flag to be removed. Having a different prefix could rather be a motivation for a flag to be renamed to a consistent name. Could you please describe the problem being solved? That will help to clarify if this patch is really needed. Reinette
