On 4/17/23 07:23, Dave Hansen wrote: > On 4/14/23 19:24, Bagas Sanjaya wrote: >> On 4/14/23 10:17, K Prateek Nayak wrote: >>> + - cluster_id: >>> + >>> + A per-CPU variable containing: >>> + >>> + - Upper bits extracted from the APIC ID. CPUs which have the same value >>> + in these bits share an L2 and have the same cluster_id. >>> + >>> + CPUs for which cluster information is unavailable will show 65535 >>> + (BAD_APICID) as the cluster_id. >> "... return cluster_id of 65535 (BAD_APICID)." > > Bagas, this is talking about a per-cpu variable. Variables don't > "return" things, functions do. > Oops, I don't see that! > I also have a request: I'd really appreciate if you could avoid > reviewing x86-related documentation. The review comments that I've seen > coming from you have not helped x86 documentation. They've hurt the > patches more than they have helped. > OK, thanks! -- An old man doll... just what I always wanted! - Clara
