Am Dienstag, 14. März 2023, 19:32:17 CET schrieb Evan Green: > We have an implicit set of base behaviors that userspace depends on, > which are mostly defined in various ISA specifications. > > Co-developed-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> > Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> > Signed-off-by: Evan Green <evan@xxxxxxxxxxxx> > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> This needs one fix, described blow, with that applied: Reviewed-by: Heiko Stuebner <heiko.stuebner@xxxxxxxx> > + case RISCV_HWPROBE_KEY_IMA_EXT_0: > + pair->value = 0; > + if (has_fpu()) > + pair->value |= RISCV_HWPROBE_IMA_FD; > + > + if (elf_hwcap & RISCV_ISA_EXT_c) This wants to be if (elf_hwcap & riscv_isa_extension_mask(c)) i.e. elf_hwcap is a bitmap, RISCV_ISA_EXT_c is the number "2" and riscv_isa_extension_mask() will get you the shifted bit. > + pair->value |= RISCV_HWPROBE_IMA_C; > + > + break; > > /* > * For forward compatibility, unknown keys don't fail the whole > Heiko
