On Mon, Feb 20, 2023 at 10:27:01AM +0000, Lucero Palau, Alejandro wrote: > > On 2/19/23 13:24, Simon Horman wrote: > > Hi Alejandro, > > > > On Sat, Feb 18, 2023 at 12:56:20AM +0000, alejandro.lucero-palau@xxxxxxx wrote: > >> From: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx> > >> > >> Add an embarrassingly missed semicolon plus and embarrassingly missed > >> parenthesis breaking kernel building in ia64 configs. > > I think this statement is slightly misleading. > > > > The problem may have manifested when building for ia64 config. > > However, I don't believe that it is, strictly speaking, an ia64 issue. > > Rather, I believe the problem is build without CONFIG_RTC_LIB. > > > > Some architectures select CONFIG_RTC_LIB., f.e. x86_64. But some do not. > > ia64 is one such example. arm64 is another - indeed I was able to reproduce > > the bug when building for arm64 using config based on the one at the link > > below. > > > > I think it would be helpful to update the patch description accordingly. > > > > Code change looks good to me: I exercised builds for both ia64 and arm64. > > > Hi Simon, > > I agree. In fact, I did not initially specify ia64 in the subject, but I > got a warning suggesting maybe I should do it. > > I guess that suggestion is likely due to adding the Reported and Link > tags, but as you say, it is not describing the problem properly. > > I will change it in v4. > > Thanks, and thank you for testing. Likewise, thanks.
