Hi Alejandro, On Sat, Feb 18, 2023 at 12:56:20AM +0000, alejandro.lucero-palau@xxxxxxx wrote: > From: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx> > > Add an embarrassingly missed semicolon plus and embarrassingly missed > parenthesis breaking kernel building in ia64 configs. I think this statement is slightly misleading. The problem may have manifested when building for ia64 config. However, I don't believe that it is, strictly speaking, an ia64 issue. Rather, I believe the problem is build without CONFIG_RTC_LIB. Some architectures select CONFIG_RTC_LIB., f.e. x86_64. But some do not. ia64 is one such example. arm64 is another - indeed I was able to reproduce the bug when building for arm64 using config based on the one at the link below. I think it would be helpful to update the patch description accordingly. Code change looks good to me: I exercised builds for both ia64 and arm64. > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@xxxxxxxxx/ > Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100") > Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx> > --- > drivers/net/ethernet/sfc/efx_devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c > index d2eb6712ba35..c829362ca99f 100644 > --- a/drivers/net/ethernet/sfc/efx_devlink.c > +++ b/drivers/net/ethernet/sfc/efx_devlink.c > @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx, > GET_VERSION_V2_OUT_SUCFW_BUILD_DATE); > rtc_time64_to_tm(tstamp, &build_date); > #else > - memset(&build_date, 0, sizeof(build_date) > + memset(&build_date, 0, sizeof(build_date)); > #endif > build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID); > > -- > 2.17.1 >
