On Mon, Nov 07, 2022 at 03:20:34PM +0100, Petr Mladek wrote: > On Mon 2022-11-07 13:18:52, Andy Shevchenko wrote: > > On Sun, Nov 06, 2022 at 11:03:55PM +0900, Hyeonggon Yoo wrote: > > > dump_page() uses %pGp format to print 'flags' field of struct page. ... > > > [ 1.816443] page_type: 0xffffffff() > > > > Why do we have empty parentheses? I would expect either something there, or no > > parentheses at all. > > This looks fine. format_page_flags() does the same for %pGp. ... > > > + %pGt 0xffefffff(slab) > > > > No space before ( ? > > Also looks fine. %pGp does the same. Maybe we can modify them before or after this change? -- With Best Regards, Andy Shevchenko
