> +struct ethtool_link_ext_stats { > + /* Custom Linux statistic for PHY level link down events. > + * In a simpler world it should be equal to netdev->carrier_down_count > + * unfortunately netdev also counts local reconfigurations which don't > + * actually take the physical link down, not to mention NC-SI which, > + * if present, keeps the link up regardless of host state. > + * This statistic counts when PHY _actually_ went down, or lost link. > + */ > + u64 link_down_events; Might be worth a comment why this is a u64 even when the uAPI has a u32. Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Andrew