On Mon, Oct 31, 2022 at 10:26 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > The previous attempt to augment carrier_down (see Link) > was not met with much enthusiasm so let's do the simple > thing of exposing what some devices already maintain. > Add a common ethtool statistic for link going down. > Currently users have to maintain per-driver mapping > to extract the right stat from the vendor-specific ethtool -S > stats. carrier_down does not fit the bill because it counts > a lot of software related false positives. > > Add the statistic to the extended link state API to steer > vendors towards implementing all of it. > > Implement for bnxt and all Linux-controlled PHYs. mlx5 and (possibly) > enic also have a counter for this but I leave the implementation > to their maintainers. > > Link: https://lore.kernel.org/r/20220520004500.2250674-1-kuba@xxxxxxxxxx > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > -- > v3: > - make the stat u32 (apart from the ethtool struct which uses u64s > for the "not set" detection, whatevs) > v2: > - add phylib support Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
