Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> writes: > From: Manfred Spraul <manfred.spraul@xxxxxxxxxxxx> > > The magic number documentation refers to old values for > NBD_REQUEST_MAGIC and NBD_REPLY_MAGIC: The documented values were used > until Linux 2.1.116pre2. > > Thus: > - Update the documentation. > - Update the header file: The authorative source for the nbd protocol > is proto.md from the nbd package, thus mention this. > - Remove the historic values from the header file. > The historic values are still documented in proto.md from the nbd > package. > > Removing the historic values is intentional: > The values are stale for > 20 years, and this was not noticed. > My guess is that everyone used grep to confirm that the values are > still in use - and the historic values resulted that there were > still hits with grep, ... > > Signed-off-by: Manfred Spraul <manfred.spraul@xxxxxxxxxxxx> > Link: https://github.com/NetworkBlockDevice/nbd/commit/107356ee528eb30744d518a8ac1cb6d379da4868 > Link: https://lore.kernel.org/all/20220318200446.14648-1-manfred@xxxxxxxxxxxxxxxx/ > Link: https://lists.debian.org/nbd/2022/01/msg00039.html > --- > V2: > - more links added, especially a link to the commit for proto.md > - typo corrected in the commit summary > > @Jonathan: > I've created one patch that updates the English text and the 3 translations > that contain magic-number.rst. > Is this the right approach? I could also split the patch into 4 changes. No, for something like this, it's fine to fix everything together. Applied, thanks. jon
