On Wed, 5 Jun 2013 19:49:30 -0700 Kees Cook <keescook@xxxxxxxxxxxx> wrote: > Avoid strncpy anti-pattern. Use strdup() instead, as already done for > the logfile optarg. > What Andreas said :) From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix remove the str[cpy|dup] altogether Cc: Andreas Schwab <schwab@xxxxxxxxxxxxxx> Cc: Kees Cook <keescook@xxxxxxxxxxxx> Cc: Rob Landley <rob@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- Documentation/accounting/getdelays.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN Documentation/accounting/getdelays.c~documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix Documentation/accounting/getdelays.c --- a/Documentation/accounting/getdelays.c~documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix +++ a/Documentation/accounting/getdelays.c @@ -299,7 +299,7 @@ int main(int argc, char *argv[]) break; case 'C': containerset = 1; - containerpath = strdup(optarg); + containerpath = optarg; break; case 'w': logfile = strdup(optarg); _ -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
