On Mon, Jun 10, 2013 at 11:58:38AM +0100, Srinivas KANDAGATLA wrote: > Thanks for testing... > On 10/06/13 11:40, Mark Rutland wrote: > > On Mon, Jun 10, 2013 at 10:27:57AM +0100, Srinivas KANDAGATLA wrote: > >> > This patch adds stih415 and stih416 support to multi_v7_defconfig. > > This seems to drop a few options also: > > > > CONFIG_ARM_ARCH_TIMER > > Same as last comment 2: > > CONFIG_ARM_ERRATA_754322 > ARM_ERRATA_754322 gets selected by the mach level Kconfig of stixxxx, so > it disappears, Should the mach level Kconfig select that? > I couldn't find the patch adding mach-stixxxx's Kconfig, though I seem to be missing patch 6 of the series. As long as CONFIG_ARM_ERRATA_754322 appears in the resulting .config, it should be fine. > > CONFIG_EXPERIMENTAL > > CONFIG_GPIO_PL061 > > CONFIG_MMC_WMT > > Comment 2: Without any modifications to multi_v7_defconfig if I run > savedefconfig CONFIG_ARM_ARCH_TIMER, CONFIG_EXPERIMENTAL, > CONFIG_GPIO_PL061 and CONFIG_MMC_WMT disappears. > Which suggests that these options seems to be selected by another > kconfigs or mach level. And since then the multi_v7_defconfig was not > run with savedefconfig. CONFIG_EXPERIMENTAL's gone as of 3d374d09f1: "final removal of CONFIG_EXPERIMENTAL", so that's fine to go. CONFIG_GPIO_PL061 and CONFIG_MMC_WMT get selected elsewhere, so that's fine. It looks like the architected timer deselection is fallout of my own making, the multi_v7_defconfig should now contain HAVE_ARM_ARCH_TIMER rather than ARM_ARCH_TIMER. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html