> While the code is OK, on second thought I think based on Andrew's points in the > other subthread that we are better off without this patch. I agree, although the rtl8365mb name will make it harder for a newcomer to find the driver. Is it too late to get rid of all those compatible strings from dt-bindings? And rtl8367s from the driver? We must add all supported devices to the doc as well, similar to mv88e6085. Regards, Luiz