On Mon, Apr 11, 2022 at 06:04:07PM -0300, Luiz Angelo Daros de Luca wrote:
> RTL8367RB-VB was not mentioned in the compatible table, nor in the
> Kconfig help text.
>
> The driver still detects the variant by itself and ignores which
> compatible string was used to select it. So, any compatible string will
> work for any compatible model.
This is not quite true: a compatible string of realtek,rtl8366rb will select the
other subdriver, assuming it is available.
Besides that small inaccuracy, I think your description is missing one crucial
bit of information, which is that the chip ID/version of the '67RB is already
included in the driver. Otherwise it reads as though the '67RB has the same ID
as one of the already-supported chips ('65MB or '67S).
With the above clarifications:
Reviewed-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
Kind regards,
Alvin
>
> Reported-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>
> ---
> drivers/net/dsa/realtek/Kconfig | 3 ++-
> drivers/net/dsa/realtek/realtek-mdio.c | 1 +
> drivers/net/dsa/realtek/realtek-smi.c | 4 ++++
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig
> index b7427a8292b2..8eb5148bcc00 100644
> --- a/drivers/net/dsa/realtek/Kconfig
> +++ b/drivers/net/dsa/realtek/Kconfig
> @@ -29,7 +29,8 @@ config NET_DSA_REALTEK_RTL8365MB
> depends on NET_DSA_REALTEK_SMI || NET_DSA_REALTEK_MDIO
> select NET_DSA_TAG_RTL8_4
> help
> - Select to enable support for Realtek RTL8365MB-VC and RTL8367S.
> + Select to enable support for Realtek RTL8365MB-VC, RTL8367RB-VB
> + and RTL8367S.
>
> config NET_DSA_REALTEK_RTL8366RB
> tristate "Realtek RTL8366RB switch subdriver"
> diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c
> index 31e1f100e48e..a36b0d8f17ff 100644
> --- a/drivers/net/dsa/realtek/realtek-mdio.c
> +++ b/drivers/net/dsa/realtek/realtek-mdio.c
> @@ -267,6 +267,7 @@ static const struct of_device_id realtek_mdio_of_match[] = {
> #endif
> #if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB)
> { .compatible = "realtek,rtl8365mb", .data = &rtl8365mb_variant, },
> + { .compatible = "realtek,rtl8367rb", .data = &rtl8365mb_variant, },
> { .compatible = "realtek,rtl8367s", .data = &rtl8365mb_variant, },
> #endif
> { /* sentinel */ },
> diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c
> index 2243d3da55b2..c2200bd23448 100644
> --- a/drivers/net/dsa/realtek/realtek-smi.c
> +++ b/drivers/net/dsa/realtek/realtek-smi.c
> @@ -556,6 +556,10 @@ static const struct of_device_id realtek_smi_of_match[] = {
> .compatible = "realtek,rtl8365mb",
> .data = &rtl8365mb_variant,
> },
> + {
> + .compatible = "realtek,rtl8367rb",
> + .data = &rtl8365mb_variant,
> + },
> {
> .compatible = "realtek,rtl8367s",
> .data = &rtl8365mb_variant,
> --
> 2.35.1
>
