On 2/24/22 03:10, Muchun Song wrote: > On Thu, Feb 24, 2022 at 3:48 AM Joao Martins <joao.m.martins@xxxxxxxxxx> wrote: >> >> In preparation for describing a memmap with compound pages, move the >> actual pte population logic into a separate function >> vmemmap_populate_address() and have vmemmap_populate_basepages() walk >> through all base pages it needs to populate. >> >> While doing that, change the helper to use a pte_t* as return value, >> rather than an hardcoded errno of 0 or -ENOMEM. >> >> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx> > > Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx> I've added this one too, thanks for the thorough review!