On 2/24/22 03:02, Muchun Song wrote: > On Thu, Feb 24, 2022 at 3:48 AM Joao Martins <joao.m.martins@xxxxxxxxxx> wrote: >> >> In support of using compound pages for devmap mappings, plumb the pgmap >> down to the vmemmap_populate implementation. Note that while altmap is >> retrievable from pgmap the memory hotplug code passes altmap without >> pgmap[*], so both need to be independently plumbed. >> >> So in addition to @altmap, pass @pgmap to sparse section populate >> functions namely: >> >> sparse_add_section >> section_activate >> populate_section_memmap >> __populate_section_memmap >> >> Passing @pgmap allows __populate_section_memmap() to both fetch the >> vmemmap_shift in which memmap metadata is created for and also to let >> sparse-vmemmap fetch pgmap ranges to co-relate to a given section and pick >> whether to just reuse tail pages from past onlined sections. >> >> While at it, fix the kdoc for @altmap for sparse_add_section(). >> >> [*] https://lore.kernel.org/linux-mm/20210319092635.6214-1-osalvador@xxxxxxx/ >> >> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx> >> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> > > Missed my Reviewed-by from previous version. Sorry my distration, I was sure I had that added in. Anyways, I've fixed now for real. Joao
