Re: [PATCH] notifier/panic: Introduce panic_notifier_filter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/01/2022 20:07, Andy Shevchenko wrote:
> [...] 
>     +       if (!buf)
>     +               return -EINVAL;
> 
> 
> I also implied that you don’t need this condition.
> 
>     +       while ((func = strsep(&buf, ","))) {
>     +               addr = kallsyms_lookup_name(func);
> 
>  
> 
>     +
> 
> 
> Btw, this is redundant blank line.
>  
> 
>     +               if (!addr) {

Thanks Andy, just submitted a V4 that incorporates your suggestions.
Cheers,


Guilherme



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux