On Fri, Dec 17, 2021 at 05:53:45PM -0800, Linus Torvalds wrote: > But honestly, at least for the second case, if somebody does a GUP, > and then starts playing mprotect games on the same virtual memory area > that they did a GUP on, and are surprised when they get another COW > fault that breaks their own connection with a page they did a GUP on > earlier, that's their own fault. I've been told there are real workloads that do this. Something like qemu will use GUP with VFIO to insert PCI devices into the guest and GUP with RDMA to do fast network copy of VM memory during VM migration. qemu also uses the WP games to implement dirty tracking of VM memory during migration (and more? I'm not sure). It expects that during all of this nothing will COW the pages, as the two kinds of DMA must always go to the pages mapped to KVM. The big trouble here is this all worked before, so it is a userspace visible regression. Can this be made to work at all? I wonder if qemu uses MAP_SHARED, eg via a memfd or something, does the COW then go away naturally? Jason
