Hi Sekhar,
On Thu, Mar 14, 2013 at 14:46:54, Nori, Sekhar wrote:
> On 3/12/2013 1:40 PM, Manjunathappa, Prakash wrote:
> > From: Murali Karicheri <m-karicheri2@xxxxxx>
> >
> > Get back missed out binding documentation submitted along
> > with below patch:
> > "spi/davinci: add OF support for the spi controller"
>
> This is not really the correct description of this patch. Years later
> its mostly irrelevant that binding documentation did not get applied
> along with the actual usage.
>
Agreed, I will change the commit message. This could have been below
scissors lines
> >
> > [prakash.pm@xxxxxx: Follow DT naming convention for compatible property]
> > Signed-off-by: Murali Karicheri <m-karicheri2@xxxxxx>
> > Reviewed-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
> > Signed-off-by: Manjunathappa, Prakash <prakash.pm@xxxxxx>
> > ---
> > .../devicetree/bindings/spi/spi-davinci.txt | 51 ++++++++++++++++++++
> > 1 files changed, 51 insertions(+), 0 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/spi/spi-davinci.txt
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-davinci.txt b/Documentation/devicetree/bindings/spi/spi-davinci.txt
> > new file mode 100644
> > index 0000000..75ad9ac
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/spi-davinci.txt
> > @@ -0,0 +1,51 @@
> > +Davinci SPI controller device bindings
> > +
> > +Required properties:
> > +- #address-cells: number of cells required to define a chip select
> > + address on the SPI bus. Should be set to 1.
> > +- #size-cells: should be zero.
> > +- compatible:
> > + - "ti,dm6441-spi" for SPI used similar to that on DM644x SoC family
> > + - "ti,da830-spi" for SPI used similar to that on DA8xx SoC family
> > +- reg: Offset and length of SPI controller register space
> > +- num-cs: Number of chip selects
> > +- ti,davinci-spi-intr-line: interrupt line used to connect the SPI
> > + IP to the interrupt controller withn the SoC. Possible values
> > + are 0 and 1. Manual says one of the two possible interrupt
> > + lines can be tied to the interrupt controller. Set this
> > + based on a specifc SoC configuration.
> > +- interrupts: interrupt number mapped to CPU.
> > +- clocks: spi clk phandle
> > +
> > +Example of a NOR flash slave device (n25q032) connected to DaVinci
> > +SPI controller device over the SPI bus.
> > +
> > +spi0:spi@20BF0000 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "ti,dm6446-spi";
> > + reg = <0x20BF0000 0x1000>;
> > + num-cs = <4>;
> > + ti,davinci-spi-intr-line = <0>;
> > + interrupts = <338>;
> > + clocks = <&clkspi>;
> > +
> > + flash: n25q032@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "st,m25p32";
> > + spi-max-frequency = <25000000>;
> > + reg = <0>;
> > +
> > + partition@0 {
> > + label = "u-boot-spl";
> > + reg = <0x0 0x80000>;
> > + read-only;
> > + };
> > +
> > + partition@1 {
> > + label = "test";
> > + reg = <0x80000 0x380000>;
> > + };
> > + };
>
> Looks like the tabs were messed up when you took Murali's patch.
>
Ok I will fix this.
Thanks,
Prakash
��.n��������+%������w��{.n�����{����* jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
