On Thu, 1 Nov 2012, Wen Congyang wrote: > >> diff --git a/drivers/base/node.c b/drivers/base/node.c > >> index af1a177..5d7731e 100644 > >> --- a/drivers/base/node.c > >> +++ b/drivers/base/node.c > >> @@ -614,23 +614,23 @@ static ssize_t show_node_state(struct device *dev, > >> { __ATTR(name, 0444, show_node_state, NULL), state } > >> > >> static struct node_attr node_state_attr[] = { > >> - _NODE_ATTR(possible, N_POSSIBLE), > >> - _NODE_ATTR(online, N_ONLINE), > >> - _NODE_ATTR(has_normal_memory, N_NORMAL_MEMORY), > >> - _NODE_ATTR(has_cpu, N_CPU), > >> + [N_POSSIBLE] = _NODE_ATTR(possible, N_POSSIBLE), > >> + [N_ONLINE] = _NODE_ATTR(online, N_ONLINE), > >> + [N_NORMAL_MEMORY] = _NODE_ATTR(has_normal_memory, N_NORMAL_MEMORY), > >> #ifdef CONFIG_HIGHMEM > >> - _NODE_ATTR(has_high_memory, N_HIGH_MEMORY), > >> + [N_HIGH_MEMORY] = _NODE_ATTR(has_high_memory, N_HIGH_MEMORY), > >> #endif > >> + [N_CPU] = _NODE_ATTR(has_cpu, N_CPU), > >> }; > >> > > > > Why change the index for N_CPU? > > N_CPU > N_HIGH_MEMORY > > We use this array to create attr file in sysfs. So changing the index for N_CPU > doesn't cause any other problem. > Acked-by: David Rientjes <rientjes@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html