Le Mon, 20 Aug 2012 16:54:27 +0200, Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> a écrit : > On 08/20/2012 04:31 PM, Linus Walleij wrote: > > On Sat, Aug 11, 2012 at 2:56 PM, Sebastian Hesselbarth > > <sebastian.hesselbarth@xxxxxxxxx> wrote: > >> +CONFIG_PINCTRL_ARMADA_370=y > >> +CONFIG_PINCTRL_ARMADA_XP=y > > > > If the system is not even booting without pinctrl you should > > (IMHO) select these from the machine's Kconfig entry insteaf. > > I don't have a strong opinion on this but I think most systems > will boot just fine without pinctrl. The basic stuff is set up > by u-boot. Anyway, I think we should enable pinctrl for each soc > by default. Yes, the system boots fine without the pinctrl support. So I don't think that MACH_ARMADA_370_XP should forcefully select the pinctrl code, but it's nice to have the default defconfig for this platform select the pinctrl support. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html