On Wednesday 20 June 2012, Laxman Dewangan wrote: > Match the device's regulators with the property of > "regulator-compatible" of each regulator node. > > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> > Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx> > --- > Changes from V1: > - In place of adding new api, modify the existing api of_regulator_match() to > look regulator-compatible for matching. > > Changes from V2: > - Add break if the regualtor match found. I've read the entire series a few times and I still can't figure out why you're doing it. *Please* describe what the change is good for, now what you are doing in it. All I can tell from the patch and/or description right now is that you are adding a third identifier next the phandle and the "regulalator-name", but not why this is a good idea. Specifically, please explain these two things in the changelog: 1. What is it that the new property can express that cannot already be expressed by using the phandle. 2. Why is it called "regulator-compatible"? If it's similar to the "compatible" property, don't you have to have a binding for each possible string? If it's not related to the "compatible" property, why is it named in a similar way? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
