On Mon, Jun 04, 2012 at 03:36:55AM -0700, Sagar Dharia wrote: > I would expect that the slim_device's driver will only power-on the device > during probe (and use wait_for_completion during 1st transfer to get LA). > Typically transfers are not done as part of probe. Even if transfers need I'd really expect that we'll have devices that we want to interact with during probe, for example to determine the device variant. I'd also expect that it'd be useful to defer things like registering the device with higher level APIs until we've actually got it up and running, it tends to make life simpler. > to be done as part of probe, I expect wait_for_completion (with timeout to > avoid potential HW problems causing linux probe to wait forever) will be > better than polling for get_logical_addr. I agree that a completion is better if we have to block in the device driver, but the idea someone suggested of having the framework generate a second callback when it's assigned a logical address seems even better.
Attachment:
signature.asc
Description: Digital signature
