> These are initial comments. A full review of the patch will take some > time. While I am posting this email, this is the result of work both > by myself, and my colleague Greg Clemson (cc'ed). > Thank you Marc and Greg for taking time to review this. > The enumeration slim_ch_proto is incorrect. It declares 2 transport > protocols which do not exist in the specification: SLIM_HARD_ISO; > SLIM_AUTO_ISO. The enums are more SW representation (and not 1-1 mapping). Difference between HARD_ISO and AUTO_ISO with example: Let's say the root frequency is 24.576MHz. then all 4K family channels (sample rate multiple of 4K) can run isochronously, and all 11.025KHz channel can run with good efficiency. So if a client wants 11.025KHz and is does not want to do flow-control at this root frequency, then the client can specify AUTO_ISO to get the next available isochronous frequency. > I suggest that term "enumeration address" should be used. > Thank you for catching this. I will change it where-ever applicable. > b) Similarly to (a) the driver may be probed before the device has > been given a logical address (LA). This makes sense in the case of > driver that turns on the device (say via gpio) once the bus has > booted. However, the driver then needs to sit and poll > slim_get_logical_addr() until the logical address. This is not the case anymore. While taking care of the comments for RFC, I have introduced a completion that will be signalled when LA is given to the device. The driver can wait on that completion (wait_enum) instead of polling. Regards Sagar Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
