On Fri, Feb 26, 2010 at 12:17 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > On Thu, 2010-02-25 at 23:45 +0800, Dave Young wrote: >> + if (!atomic_read(&l)) >> + atomic_set(&l, printk_delay_lines); > > That's racy, use atomic_cmpxchg() Will fix, thanks > >> + smp_mb__before_atomic_dec(); >> + if (atomic_dec_return(&l)) >> + return; > > What's that barrier for? Will fix, no memory operation here -- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
