On Thu, 2010-02-25 at 23:45 +0800, Dave Young wrote: > + if (!atomic_read(&l)) > + atomic_set(&l, printk_delay_lines); That's racy, use atomic_cmpxchg() > + smp_mb__before_atomic_dec(); > + if (atomic_dec_return(&l)) > + return; What's that barrier for? -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html