Hello Guo, On Wed, 29 May 2019 16:30:43 +0800 Guo Ren <guoren@xxxxxxxxxx> wrote: > OK, change the commit log with: > > C-SKY CPU is seperated into two ABIs: > - abiv1: mcore based ELF_NUM:39 and do not support FPU & VDSP. (CPU: 610) > - abiv2: C-SKY own ISA with ELF_NUM:252 and support FPU & VDSP. (CPU: > 807, 810, 860) > > So we don't care BR2_GCC_TARGET_FLOAT_ABI for abiv1, because it based > on CSKY_FPU and it'll > never be selected by ck610. This last part is not correct: BR2_GCC_TARGET_FLOAT_ABI *will* have a value for abiv1. Except the value will always be "soft" because there's no FPU support in ck610, which is the only core using abiv1. So saying "We don't care about BR2_GCC_TARGET_FLOAT_ABI for abiv1" is not correct. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com