On Wed, May 29, 2019 at 3:57 PM Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> wrote: > > Hello, > > On Wed, 29 May 2019 15:30:14 +0800 > Guo Ren <guoren@xxxxxxxxxx> wrote: > > > > What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is > > > apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is > > > defined for all cases, which seems to contradict your commit log. > > abiv1 contain: ck610 > > abiv2 contain: ck807 ck810 ck860 > > > > Abiv1 is almost the same as mcore and it's ELF_CODE is 39 > > Abiv2 is C-SKY own ISA and it's ELF_CODE is 252 > > > > We don't support FPU in abiv1, because its opcode width is only > > 16-bits and we don't want to continue developing it. > > Ah, and indeed BR2_CSKY_FPU cannot be selected for BR2_ck610. > > Please explain all of this in the commit log. Thanks! > OK, change the commit log with: C-SKY CPU is seperated into two ABIs: - abiv1: mcore based ELF_NUM:39 and do not support FPU & VDSP. (CPU: 610) - abiv2: C-SKY own ISA with ELF_NUM:252 and support FPU & VDSP. (CPU: 807, 810, 860) So we don't care BR2_GCC_TARGET_FLOAT_ABI for abiv1, because it based on CSKY_FPU and it'll never be selected by ck610.