On Tue, Mar 4, 2025 at 11:41 PM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Mar 05, 2025 at 06:18:25AM +0000, Yosry Ahmed wrote: > > > > I think there are other motivations for zcomp. Nhat was actually talking > > about switch zswap to use zcomp for other reasons. Please see this > > thread: > > https://lore.kernel.org/lkml/CAKEwX=O8zQj3Vj=2G6aCjK7e2DDs+VBUhRd25AefTdcvFOT-=A@xxxxxxxxxxxxxx/. > > The only reason I saw was the support for algorithm parameters. > Yes that will of course be added to crypto_acomp before I attempt > to replace zcomp. For the record, that's also the only reason why I was thinking about it. :) I have no passion for zcomp or anything - as long as we support all the cases (hardware acceleration/offloading, algorithms parameters, etc.), I'm happy :) Thanks for the hard work, Herbert, and I look forward to seeing all of this work.