On Wed, Mar 05, 2025 at 11:45:27AM +0800, Herbert Xu wrote: > On Tue, Mar 04, 2025 at 08:47:48PM +0000, Yosry Ahmed wrote: > > > > Yeah I have the same feeling that the handling is all over the place. > > Also, we don't want to introduce new map APIs, so anything we do for > > zswap should ideally work for zram. > > I will be getting to zram next. AFAIK all that's missing from > acomp is parameter support. Once that is added we can convert > zram over to acomp and get rid of zcomp altogether. I think there are other motivations for zcomp. Nhat was actually talking about switch zswap to use zcomp for other reasons. Please see this thread: https://lore.kernel.org/lkml/CAKEwX=O8zQj3Vj=2G6aCjK7e2DDs+VBUhRd25AefTdcvFOT-=A@xxxxxxxxxxxxxx/.