Re: [PATCH v2] crypto: Use str_enable_disable-like helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 14, 2025 at 08:05:01PM +0100, Krzysztof Kozlowski wrote:
> Replace ternary (condition ? "enable" : "disable") syntax with helpers
> from string_choices.h because:
> 1. Simple function call with one argument is easier to read.  Ternary
>    operator has three arguments and with wrapping might lead to quite
>    long code.
> 2. Is slightly shorter thus also easier to read.
> 3. It brings uniformity in the text - same string.
> 4. Allows deduping by the linker, which results in a smaller binary
>    file.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> 
> ---
> 
> Changes in v2:
> 1. Also: drivers/crypto/caam/caamalg_qi2.c
> ---
>  drivers/crypto/bcm/cipher.c                         |  3 ++-
>  drivers/crypto/bcm/spu2.c                           |  3 ++-
>  drivers/crypto/caam/caamalg_qi2.c                   |  3 ++-
>  drivers/crypto/intel/qat/qat_common/adf_sysfs.c     | 10 +++-------
>  drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c   |  5 +++--
>  drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c |  3 ++-
>  6 files changed, 14 insertions(+), 13 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux