> -----Original Message----- > From: Yosry Ahmed <yosryahmed@xxxxxxxxxx> > Sent: Friday, November 8, 2024 12:24 PM > To: Johannes Weiner <hannes@xxxxxxxxxxx> > Cc: Sridhar, Kanchana P <kanchana.p.sridhar@xxxxxxxxx>; linux- > kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; nphamcs@xxxxxxxxx; > chengming.zhou@xxxxxxxxx; usamaarif642@xxxxxxxxx; > ryan.roberts@xxxxxxx; Huang, Ying <ying.huang@xxxxxxxxx>; > 21cnbao@xxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; linux- > crypto@xxxxxxxxxxxxxxx; herbert@xxxxxxxxxxxxxxxxxxx; > davem@xxxxxxxxxxxxx; clabbe@xxxxxxxxxxxx; ardb@xxxxxxxxxx; > ebiggers@xxxxxxxxxx; surenb@xxxxxxxxxx; Accardi, Kristen C > <kristen.c.accardi@xxxxxxxxx>; zanussi@xxxxxxxxxx; Feghali, Wajdi K > <wajdi.k.feghali@xxxxxxxxx>; Gopal, Vinodh <vinodh.gopal@xxxxxxxxx> > Subject: Re: [PATCH v3 12/13] mm: Add sysctl vm.compress-batching switch > for compress batching during swapout. > > On Thu, Nov 7, 2024 at 9:34 AM Johannes Weiner <hannes@xxxxxxxxxxx> > wrote: > > > > On Wed, Nov 06, 2024 at 11:21:04AM -0800, Kanchana P Sridhar wrote: > > > The sysctl vm.compress-batching parameter is 0 by default. If the platform > > > has Intel IAA, the user can run experiments with IAA compress batching of > > > large folios in zswap_store() as follows: > > > > > > sysctl vm.compress-batching=1 > > > echo deflate-iaa > /sys/module/zswap/parameters/compressor > > > > A sysctl seems uncalled for. Can't the batching code be gated on > > deflate-iaa being the compressor? It can still be generalized later if > > another compressor is shown to benefit from batching. > > +1 Thanks Yosry & Johannes. Will proceed as suggested. Thanks, Kanchana
