On Sun, Nov 03, 2024 at 02:31:41PM -0800, Eric Biggers wrote:
> -static int __init crc32_pmull_mod_init(void)
> -{
> - if (elf_hwcap2 & HWCAP2_PMULL) {
> - crc32_pmull_algs[0].update = crc32_pmull_update;
> - crc32_pmull_algs[1].update = crc32c_pmull_update;
> -
> - if (elf_hwcap2 & HWCAP2_CRC32) {
> - fallback_crc32 = crc32_armv8_le;
> - fallback_crc32c = crc32c_armv8_le;
> - } else {
> - fallback_crc32 = crc32_le;
> - fallback_crc32c = __crc32c_le;
> - }
> - } else if (!(elf_hwcap2 & HWCAP2_CRC32)) {
> - return -ENODEV;
> - }
[...]
> +static u32 crc32_le_scalar(u32 crc, const u8 *p, size_t len)
> +{
> + if (static_branch_likely(&have_crc32))
> + return crc32_armv8_le(crc, p, len);
> + return crc32_le_base(crc, p, len);
> +}
kernel test robot reported a build error on this patch,
"undefined symbol: __kcfi_typeid_crc32_armv8_le". It's because crc32-core.S
uses SYM_TYPED_FUNC_START(crc32_armv8_le), and this patch makes crc32_armv8_le
be called only via direct calls, not indirect calls as it was before. I will
fix this by replacing SYM_TYPED_FUNC_START by SYM_FUNC_START.
- Eric
