On Mon, Nov 04, 2024 at 08:01:36AM -0800, Darrick J. Wong wrote: > Same comment as my last reply about removing trivial helpers, but > otherwise > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > If you push this for 6.13 I'd be happy that the shash junk finally went > away. The onstack struct desc thing in the _chksum() functions was by > far the most sketchy part of the ext4/jbd2 metadata csum project. :) It will take a bit longer I'm afraid, since this patchset depends on patches that are currently enqueued in three different trees for 6.13. My current plan is to target 6.14, and get this series into into linux-next shortly after the 6.13 merge window closes. - Eric
