On Fri, Aug 02, 2024 at 08:09:10AM -0700, Andy Polyakov wrote: > Formally speaking this is error prone, because there is no guarantee that linker will be able to resolve it as argument to `adr` instruction above. I mean since the address is resolved with `adr` instruction alone, there is a limit on how far the label can be from the instruction in question. On a practical level, if/since it's compiled as part of a kernel module, it won't be a problem, because the module won't be large enough to break the limit, but it **is** a problem in general case. > > But why would objtool attempt to disassemble it? Does it actually attempt to disassemble unreferenced spaces between functions? Note that the .Lzeros label doesn't make it into .o file, so there won't be anything in the symbol table to discover as potential entry point... > > -- > Reply to this email directly or view it on GitHub: > https://github.com/herbertx/cryptodev/commit/47d96252099a7184b4bad852fcfa3c233c1d2f71#r144978326 > You are receiving this because you authored the thread. > > Message ID: <herbertx/cryptodev/commit/47d96252099a7184b4bad852fcfa3c233c1d2f71/144978326@xxxxxxxxxx> Adding the original Cc list. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
