On Sun, Jul 21, 2024 at 01:48:38AM +0100, Daniel Golle wrote:
> From: Aurelien Jarno <aurelien@xxxxxxxxxxx>
>
> Enable the just added Rockchip RNG driver for RK356x SoCs.
>
> Signed-off-by: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/rockchip/rk3568.dtsi | 7 +++++++
> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 10 ++++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index f1be76a54ceb..b9c6b2dc87fa 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -257,6 +257,13 @@ power-domain@RK3568_PD_PIPE {
> };
> };
>
> +&rng {
> + rockchip,sample-count = <1000>;
> + quality = <900>;
As I already wrote you for v7, quality is out of 1024, not 1000, so this
won't hit 90% as you intend.
But also, I think putting this in the DT is a mistake. Other drivers
don't generally do this, and if the hardware is actually the same piece
to piece (it is...), then there's not per-manufactured unit tweaking
needed. So keep this in the actual driver C like other drivers.
Jason
