On 24-07-10, Herbert Xu wrote: > On Tue, Jul 09, 2024 at 10:54:54AM +0200, Marco Felsch wrote: > > > > We had an patch exactly doing this but depending on the SoC the default > > prio may valid since the CAAM is used on ARMv7 and ARMv8 NXP SoCs. To > > not cause any regression we went this way. > > I don't understand. Why not just set the priority depending on > IS_ENABLED(CONFIG_ARM)? Argh.. you're right. I had something other in my mind, sry. > That way it's strictly better than the Kconfig patch: > > 1) If the driver is indeed slower then you'd have achieved the same > result of preferring the non-driver algorithm. > > 2) If the driver ends up being faster then at least the admin can > adjust the priorities. > > Or perhaps your Kconfig option should set the priority. NACK since no admin knows the prios. I will go with the "IS_ENABLED" solution, thank you! Regards, Marco > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt >
