On Fri, Jun 28, 2024 at 04:41:17PM +0800, WangYuli wrote: > When entering the "len & sizeof(u32)" branch, len must be less than 8. > So after one operation, len must be less than 4. > At this time, "len -= sizeof(u32)" is not necessary for 64-bit CPUs. > > A similar issue has been solved at Loongarch. > > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.10-rc5&id=fea1c949f6ca5059e12de00d0483645debc5b206 > Signed-off-by: Guan Wentao <guanwentao@xxxxxxxxxxxxx> > Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx> > --- > arch/mips/crypto/crc32-mips.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/mips/crypto/crc32-mips.c b/arch/mips/crypto/crc32-mips.c > index ec6d58008f8e..505d2d897849 100644 > --- a/arch/mips/crypto/crc32-mips.c > +++ b/arch/mips/crypto/crc32-mips.c > @@ -94,7 +94,9 @@ static u32 crc32_mips_le_hw(u32 crc_, const u8 *p, unsigned int len) > > CRC32(crc, value, w); > p += sizeof(u32); > +#ifndef CONFIG_64BIT > len -= sizeof(u32); > +#endif First of all, did you verify that this actually makes a difference? Please post the actual assembly output with and without this patch. If it does make a difference, you should avoid doing ifdefs as they are more likely to cause build failures. Instead do something like if (!IS_ENABLED(CONFIG_64BIT)) len -= sizeof(u32); Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
